Update my-slider.ts #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue AnthonMS#29. Tested with MacOS Safari Version 15.5 and Safari on iOS 15.6
|
Looks good. I thought it might have been an easy fix like this, but I haven't had time setting up MacOS on a virtual machine yet. But thank you for your contribution! |
|
Still not working on iPadOS 15 and 16 beta. |
|
Just clearing out, V2 is working fine on iPadOS15 and iPadOS16 beta 2, tested horizontal and vertical. I told Anthon it was not working but it seems to be a cache issue. Finally iOS, iPadOS and Safari users can now use the slider anywhere instead of using the Thumb. Great work guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #29. Tested with MacOS Safari Version 15.5 and Safari on iOS 15.6
Description
Related Issue
Solves issue #29.
https://github.com/AnthonMS/my-cards/issues/29
Motivation and Context
Solves issue #29.
How Has This Been Tested
Tested with MacOS Safari Version 15.5 and Safari on iOS 15.6
Types of changes
Checklist